Adding example_rift_estimation.cpp to examples in trunk

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Adding example_rift_estimation.cpp to examples in trunk

Karthik Desingh
Hi, 
I have written an example for rift estimation and would like to add it to the examples folder in the trunk.

Following are the things i have done
1. Tested the example locally
2. Made sure that its in the style of PCL
3. Copied the Licence Disclaimer from the other example

Queries:
1. Am i right in adding the Licence Disclaimer myself? 
2. Is the $id: <name_of_cpp> <time> <author> added manually?
3. I will add the below line in the CMakeLists.txt. Is it correct?

PCL_ADD_EXAMPLE(pcl_example_rift_estimation FILES example_rift_estimation.cpp
                LINK_WITH pcl_common pcl_kdtree pcl_search pcl_features pcl_io)

Pls let me know if i am missing something here.

--
Thanks,
Karthik


_______________________________________________
PCL-developers mailing list
[hidden email]
http://pointclouds.org/mailman/listinfo/pcl-developers
http://pointclouds.org
Reply | Threaded
Open this post in threaded view
|

Re: Adding example_rift_estimation.cpp to examples in trunk

Radu B. Rusu
Administrator
Karthik,


On 03/16/2012 03:19 AM, Karthik Desingh wrote:

> Hi,
> I have written an example for rift estimation and would like to add it to the examples folder in the trunk.
>
> Following are the things i have done
> 1. Tested the example locally
> 2. Made sure that its in the style of PCL
> 3. Copied the Licence Disclaimer from the other example
>
> Queries:
> 1. Am i right in adding the Licence Disclaimer myself?

Yup! Your own code is your own copyright :) Unless the code contains explicit large/important portions of code from
other bits of PCL, you don't have to add any other copyrights at all.

> 2. Is the $id: <name_of_cpp> <time> <author> added manually?

Add one line by copy-pasting it from some other file. Then:

  $ svn propset svn:keywords myfile

> 3. I will add the below line in the CMakeLists.txt. Is it correct?
>
> PCL_ADD_EXAMPLE(pcl_example_rift_estimation FILES example_rift_estimation.cpp
>                 LINK_WITH pcl_common pcl_kdtree pcl_search pcl_features pcl_io)

Looks good! Thanks in advance for your contribution!

Cheers,
Radu.
_______________________________________________
PCL-developers mailing list
[hidden email]
http://pointclouds.org/mailman/listinfo/pcl-developers
http://pointclouds.org